Performance improvements to docs #2730
Conversation
|
1 -> 91 🔥🔥🔥 |
pngwn
left a comment
There was a problem hiding this comment.
I'm not seeing the 91, i get ~60 after a few tries but ~1 -> ~60 is huge. There is also a noticeable improvement in performance even without using automated testing. The old version of the docs is frequently unusable, even on desktop for me and closing it takes many seconds + locks up my browser. On mobile the current docs are completely unusable.
Regardless of whether it is 60 or 90 we should ship this asap, huge improvement. Awesome work @aliabd!
|
Hmm that's weird @pngwn, are you sure that's for /docs/main on www.gradio-staging.com and testing for mobile? I just got 93. I did see high 80s a few times but never 60. Maybe it's a latency thing! But yes, the number doesn't really matter. |
|
Btw @pngwn do you know how we'd enable text compression on the gradio.js served from s3? like https://gradio.s3-us-west-2.amazonaws.com/3.11.0/gradio.js I think we'll have to zip them before uploading to s3. but not sure if there's a better way? |
|
LGTM @aliabd! The staging website loads significantly faster for me on desktop as well. The CircleCI test that is failing is because the Hub is down. Rerunning that should cause it to pass (although we should mark it flaky for future reference) |
|
Will try to figure out gzipping the gradio.js s3 module on a separate PR |
I made some performance improvements to the docs, especially on mobile. I know we've talked about moving the website to a better framework, and we should still do that, but we have to make fixes now as they are currently unusable.
Before changes:
After:
Try comparing between the website and dev server on mobile. Note that most of these changes will only apply to /docs/main/ until we release a new pip version and /docs gets updated.
Closes: #2717