Skip to content

Patching test_get_ip attempt 2#2810

Merged
abidlabs merged 3 commits into
mainfrom
ip-patch-2
Dec 14, 2022
Merged

Patching test_get_ip attempt 2#2810
abidlabs merged 3 commits into
mainfrom
ip-patch-2

Conversation

@abidlabs
Copy link
Copy Markdown
Member

@abidlabs abidlabs commented Dec 14, 2022

Previously, we were using https://api.ipify.org to get the IP address. But this website has started to occasionally return a "Bad Gateway" response. So I switched to https://checkip.amazonaws.com/, which should be more reliable and also marked the test as flaky as it still relies on an external service

@abidlabs abidlabs requested a review from aliabid94 December 14, 2022 02:21
@github-actions
Copy link
Copy Markdown
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2810-all-demos

Copy link
Copy Markdown
Contributor

@aliabid94 aliabid94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@abidlabs
Copy link
Copy Markdown
Member Author

Thanks @aliabid94

@abidlabs abidlabs merged commit 5182460 into main Dec 14, 2022
@abidlabs abidlabs deleted the ip-patch-2 branch December 14, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants