Fix css glitch and navigation in docs#2856
Merged
Merged
Conversation
aliabd
requested review from
abidlabs and
aliabid94
and removed request for
aliabid94
Contributor
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2856-all-demos |
| from markdown_it import MarkdownIt | ||
| from mdit_py_plugins.dollarmath import dollarmath_plugin | ||
| from pandas.api.types import is_numeric_dtype | ||
| from PIL import Image as _Image # using _ to minimize namespace pollution |
Collaborator
There was a problem hiding this comment.
Ok I was getting this locally too when I linted the backend.
I'm guessing the person who added this line had a different version of isort?
freddyaboulton
approved these changes
Dec 20, 2022
Collaborator
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
Thanks @aliabd !
Verified this fixes on main. I wonder if we can re-generate the 3.14.0 documentation as well so that it doesn't look buggy?
Contributor
Author
|
@freddyaboulton good point, I cleaned just the css glitch from 3.14 as well, although we'll probably end up releasing 3.15 very soon. But I didn't make the other fixes because I didn't want to manually change too much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes navigation issue in docs and css.
Closes #2821, closes #2822