Skip to content

Make it so that default_enabled has no impact on queue behavior#2876

Merged
freddyaboulton merged 3 commits into
mainfrom
2863-fix-default-enabled
Dec 21, 2022
Merged

Make it so that default_enabled has no impact on queue behavior#2876
freddyaboulton merged 3 commits into
mainfrom
2863-fix-default-enabled

Conversation

@freddyaboulton
Copy link
Copy Markdown
Collaborator

@freddyaboulton freddyaboulton commented Dec 21, 2022

Description

Makes it so that default_enabled has no impact on queue behavior as discussed in #2863

Closes: #2863

Checklist:

  • I have performed a self-review of my own code
  • I have added a short summary of my change to the CHANGELOG.md
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

A note about the CHANGELOG

Hello 👋 and thank you for contributing to Gradio!

All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.

Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by [@myusername](link-to-your-github-profile) in [PR 11111](https://github.com/gradio-app/gradio/pull/11111)".

If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.

@github-actions
Copy link
Copy Markdown
Contributor

All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-2876-all-demos

Comment thread gradio/blocks.py Outdated
Copy link
Copy Markdown
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirms this fixes #2863

Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
@freddyaboulton freddyaboulton merged commit 1765cf6 into main Dec 21, 2022
@freddyaboulton freddyaboulton deleted the 2863-fix-default-enabled branch December 21, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

queue=True does not work if default_enabled=False

2 participants