Skip to content

fix default_value #869

Merged
abidlabs merged 3 commits into
blocks-devfrom
default-values
Mar 26, 2022
Merged

fix default_value #869
abidlabs merged 3 commits into
blocks-devfrom
default-values

Conversation

@pngwn
Copy link
Copy Markdown
Member

@pngwn pngwn commented Mar 24, 2022

A feww issue with this one:

  • The value that is passed via the config is called default not default_value could we change this to match? default is a keyword in javascript which makes using it tricky.
  • Not every component seems to pass down the default value, we need to add this behaviour to everything and make sure it is as consistent as possible across components. HTML and JSON and Timeseries don't seem to pass down a default (unless I'm adding the default value incorrectly).

@abidlabs
Copy link
Copy Markdown
Member

Not every component seems to pass down the default value, we need to add this behaviour to everything and make sure it is as consistent as possible across components. HTML and JSON and Timeseries don't seem to pass down a default (unless I'm adding the default value incorrectly).

This should be fixed in #871. @farukozderim has added default value to the config of all of the components.

The value that is passed via the config is called default not default_value could we change this to match? default is a keyword in javascript which makes using it tricky.

This has also been fixed in the same PR #871. So if I'm reading your js code correctly in this PR, this means that this PR needs to update the property name from default to default_value? @aliabid94 if you can also take a look to confirm (and fix, if needed), that would be great so that we can components fully working statically.

@aliabid94
Copy link
Copy Markdown
Contributor

I've renamed default to default_value in the frontend and backend components in this PR.

@abidlabs abidlabs merged commit be423b7 into blocks-dev Mar 26, 2022
@abidlabs abidlabs deleted the default-values branch March 26, 2022 00:04
@omerXfaruq
Copy link
Copy Markdown
Contributor

I've renamed default to default_value in the frontend and backend components in this PR.

@aliabid94 we actually did backend part in this PR, did you see it?
#871

@abidlabs
Copy link
Copy Markdown
Member

abidlabs commented Mar 26, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants