[BIG PR] Gradio blocks & redesigned components by abidlabs · Pull Request #880 · gradio-app/gradio

abidlabs · 2022-03-25T19:23:39Z

Opening this PR as a draft so that we can start thinking about merging it into main.

Of course, before we can merge it in, we need to:

Rewrite the core Interface class in terms of Blocks
Restore the full functionality of the Interface class
Ensure that all old python unit tests pass (for backwards compatibility)
Redesign all of the components (at least at a basic level -- a full redesign can come later)

Blocks components

- default -> default_value refactoring

- refactor output types into output_type and make them auto

- all events are implemented

- refactor fn: str -> Callable

- add change event to TabItem

- Remove KeyValues from components

- Resolve Components imports in inputs and outputs

- fix default parameter usage in demos

- docstring updates

- tweaks

- add change event to Tabs

* custom-components - create template components - changes in PKG and requires comes from scripts/install_gradio.sh * custom-components - tweaks * update-components - tweaks * update-components - fix get_block_name * update-components - add webcam demo * custom-components - make use of get_block_name function whenever possible * custom-components - tweaks * refactor-component-shortcuts - no description whatsoever :D * refactor-component-shortcuts - tweaks * refactor-component-shortcuts - create shortcut function "component" * refactor-component-shortcuts - reformat * refactor-component-shortcuts - tweaks * refactor-component-shortcuts - tweaks

Create Status Tracker component to report progress on function calls Co-authored-by: Ali Abid <aliabid94@gmail.com>

* add model3D * model3d component * add plot component * format * ingnore plot.svelte from prettier * update build script * update circleci config * remove circleci config change * change build script * remove change to build script * remove plot.svelte * remove duplicate save_flagged func * fix node space issue + format issues * Update ui.yml * Update ui.yml * Update ui.yml * remove changes to config files * updated codecov version * Update ui.yml Co-authored-by: Abubakar Abid <abubakar@huggingface.co>

omerXfaruq · 2022-04-19T09:39:10Z

@aliabid94 good job, what a big PR! How was the conflict resolving part, was it too long :D
Btw is there anything we need to review on this PR?

omerXfaruq · 2022-04-19T09:47:22Z

        super().__init__(default_value=default, label=label)
+
+
+class Image3D(C_Model3D):


Do we need to add Image3D here? These are just for backwards compatibility.

omerXfaruq · 2022-04-19T09:48:02Z

 class TestImage3D(unittest.TestCase):
    def test_as_component(self):
-        Image3D = gr.test_data.BASE64_IMAGE3D
+        Image3D = media_data.BASE64_MODEL3D


it is better to deepcopy test_data in case any changes occur to them.

omerXfaruq · 2022-04-19T09:48:07Z


    def test_in_interface(self):
-        Image3D = gr.test_data.BASE64_IMAGE3D
+        Image3D = media_data.BASE64_MODEL3D


it is better to deepcopy test_data in case any changes occur to them.

omerXfaruq · 2022-04-19T09:48:39Z

-        aiohttp.ClientSession.post.assert_called()
-        self.assertEqual(response.status_code, 200)
-        io.close()
+# class TestFlagging(unittest.TestCase):


hmm, why did we comment out these tests?

omerXfaruq · 2022-04-19T09:49:02Z

        with tempfile.TemporaryDirectory() as tmpdirname:
            to_save = Image3D_output.save_flagged(
-                tmpdirname, "Image3D_output", gr.test_data.BASE64_IMAGE3D, None
+                tmpdirname, "Image3D_output", media_data.BASE64_MODEL3D, None


it is better to deepcopy test_data in case any changes occur to them.

omerXfaruq · 2022-04-19T09:49:05Z

            self.assertEqual("Image3D_output/0.gltf", to_save)
            to_save = Image3D_output.save_flagged(
-                tmpdirname, "Image3D_output", gr.test_data.BASE64_IMAGE3D, None
+                tmpdirname, "Image3D_output", media_data.BASE64_MODEL3D, None


it is better to deepcopy test_data in case any changes occur to them.

omerXfaruq · 2022-04-19T09:54:42Z

@aliabid94 this test started fail in another PR after your merge, did you had any changes about this function or data? If not it might be because of non deepcopied test_data I commented about above.

abidlabs · 2022-04-19T14:30:53Z

@aliabid94 this test started fail in another PR after your merge, did you had any changes about this function or data? If not it might be because of non deepcopied test_data I commented about above.

It was because certain files were reorganized in blocks-dev -- fixed in #1023

abidlabs and others added 30 commits March 18, 2022 16:44

fixed external tests

408f743

fixing test_inputs.py

6bcbde4

fixing test inputs

77eae45

deleted components

e95a4b3

only Number and Label outputs are interpretable

12e7333

fixed test data

db6f845

used numbers.Numbers

219adfa

fixed test inputs.py

f2a5ecd

fixed interpretation

d25419b

Merge pull request #765 from gradio-app/Blocks-Components

e80d203

Blocks components

Blocks-Components-v2

0d2c4b1

- default -> default_value refactoring

Blocks-Components-v2

b778aa5

- refactor output types into output_type and make them auto

Blocks-Backend-Events

8c21e12

- all events are implemented

cleaned up imports

f2f4d0d

updated imports to components.py

e9386f5

stop interface from erroring out

566c954

updated to use merged components

01cc894

added super basic static textbox demo

63ccf88

kinematics block

ef533b2

Blocks-Backend-Events

15c9175

- refactor fn: str -> Callable

Blocks-Backend-Events

860ea5c

- add change event to TabItem

Blocks Backend Components

21b6dcc

- Remove KeyValues from components

Blocks-Backend-Components-v2

d9cd56e

- Resolve Components imports in inputs and outputs

Blocks-Backend-Components-v2

24011e4

- fix default parameter usage in demos

Blocks-Backend-Components-v2

b2a9816

- fix default parameter usage in demos

Blocks-Backend-Components-v2

5d0d875

- fix default parameter usage in demos

Blocks-Backend-Components-v2

ba6ec35

- docstring updates

revert demos

51c9aa6

Blocks-Backend-Components-v2

c462858

- tweaks

Blocks-Backend-Components-v2

72244c3

- add change event to Tabs

omerXfaruq and others added 9 commits April 15, 2022 00:24

- typo

0e1dce6

import hotfix (#1008)

f511174

Progress indicator bar (#997)

1c2f430

Create Status Tracker component to report progress on function calls Co-authored-by: Ali Abid <aliabid94@gmail.com>

update codecov version

2f771e2

merge in master

4f1947d

merge master

c15885f

format

0312c40

aliabid94 marked this pull request as ready for review April 19, 2022 07:30

Ali Abid added 7 commits April 19, 2022 01:05

fix css

7bf3283

fix css

3ce6e63

test fixes

1089bc6

format

3a0d78f

changes

ba9eebf

fixes

7a1618a

fixes

3dfc726

aliabid94 merged commit 9492d5a into main Apr 19, 2022

aliabid94 deleted the blocks-dev branch April 19, 2022 09:24

omerXfaruq reviewed Apr 19, 2022

View reviewed changes

abidlabs mentioned this pull request Apr 19, 2022

Update readmes #1019

Closed

akx mentioned this pull request Jun 27, 2023

More proper deprecation warnings #4694

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BIG PR] Gradio blocks & redesigned components#880

[BIG PR] Gradio blocks & redesigned components#880
aliabid94 merged 305 commits into
mainfrom
blocks-dev

abidlabs commented Mar 25, 2022 •

edited

Loading

Uh oh!

omerXfaruq commented Apr 19, 2022 •

edited

Loading

Uh oh!

omerXfaruq Apr 19, 2022

Uh oh!

omerXfaruq Apr 19, 2022

Uh oh!

omerXfaruq Apr 19, 2022

Uh oh!

omerXfaruq Apr 19, 2022

Uh oh!

omerXfaruq Apr 19, 2022

Uh oh!

omerXfaruq Apr 19, 2022

Uh oh!

omerXfaruq commented Apr 19, 2022

Uh oh!

abidlabs commented Apr 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		super().__init__(default_value=default, label=label)


		class Image3D(C_Model3D):

Conversation

abidlabs commented Mar 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

omerXfaruq commented Apr 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

omerXfaruq Apr 19, 2022

Choose a reason for hiding this comment

Uh oh!

omerXfaruq Apr 19, 2022

Choose a reason for hiding this comment

Uh oh!

omerXfaruq Apr 19, 2022

Choose a reason for hiding this comment

Uh oh!

omerXfaruq Apr 19, 2022

Choose a reason for hiding this comment

Uh oh!

omerXfaruq Apr 19, 2022

Choose a reason for hiding this comment

Uh oh!

omerXfaruq Apr 19, 2022

Choose a reason for hiding this comment

Uh oh!

omerXfaruq commented Apr 19, 2022

Uh oh!

abidlabs commented Apr 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

abidlabs commented Mar 25, 2022 •

edited

Loading

omerXfaruq commented Apr 19, 2022 •

edited

Loading