Skip to content

Checking and updating more demos to use 3.0 syntax#892

Merged
abidlabs merged 12 commits into
blocks-devfrom
remaining-demos
Mar 29, 2022
Merged

Checking and updating more demos to use 3.0 syntax#892
abidlabs merged 12 commits into
blocks-devfrom
remaining-demos

Conversation

@abidlabs
Copy link
Copy Markdown
Member

@abidlabs abidlabs commented Mar 28, 2022

I've been going through more demos on the blocks-dev branch:

  • Checking them to see if they work properly (and creating issues where they don't)
  • Updating the code to use our new 3.0 syntax (merged components, etc.)

@abidlabs abidlabs requested a review from omerXfaruq March 28, 2022 15:28
@abidlabs abidlabs marked this pull request as draft March 28, 2022 15:30
@omerXfaruq omerXfaruq removed their request for review March 28, 2022 20:04
@abidlabs abidlabs marked this pull request as ready for review March 28, 2022 22:53
@abidlabs abidlabs requested a review from omerXfaruq March 28, 2022 22:53
Copy link
Copy Markdown
Contributor

@omerXfaruq omerXfaruq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than these it LGTM, good job!

Comment thread demo/digit_classifier/run.py Outdated
Comment thread demo/form_graph/run.py
Comment thread demo/fraud_detector/run.py Outdated
Comment thread demo/hello_login/run.py
@abidlabs
Copy link
Copy Markdown
Member Author

Great thanks for the review @farukozderim! Will resolve and merge

@abidlabs abidlabs merged commit d4c91aa into blocks-dev Mar 29, 2022
@abidlabs abidlabs deleted the remaining-demos branch March 29, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants