Skip to content

Interface fix#901

Merged
abidlabs merged 2 commits into
blocks-devfrom
interface-fix
Mar 29, 2022
Merged

Interface fix#901
abidlabs merged 2 commits into
blocks-devfrom
interface-fix

Conversation

@pngwn
Copy link
Copy Markdown
Member

@pngwn pngwn commented Mar 29, 2022

Some small tweaks to fix a few errors i came across with interfaces.

@pngwn pngwn requested review from abidlabs and aliabid94 March 29, 2022 13:25
@abidlabs
Copy link
Copy Markdown
Member

Thanks @pngwn! What errors does this PR fix? That way, I can test them and link potentially related issues

@pngwn
Copy link
Copy Markdown
Member Author

pngwn commented Mar 29, 2022

It was runtime errors when running the app. A few of those cannnot get length of undefined issues. It was just related to components that don't have children. I also fixed the HighlightedText: one was a regression (named colours working as part of the color_map #724 ), I think the other was #887. The carousel needs some other work, including on the backend.

The default_value changes were a pre-emptive fix because changing the value prop to default_value on the frontend will break event triggers.

@pngwn
Copy link
Copy Markdown
Member Author

pngwn commented Mar 29, 2022

In terms of testing, the kitchen_sink should work (apart from the carousel although it shouldn't error).

@abidlabs
Copy link
Copy Markdown
Member

Tested and LGTM!

@abidlabs abidlabs merged commit c1a6974 into blocks-dev Mar 29, 2022
@abidlabs abidlabs deleted the interface-fix branch March 29, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants