Blocks Tests#902
Merged
Merged
Conversation
- implement a simple test to check blocks config generation
- reformat
omerXfaruq
commented
Mar 29, 2022
| "id": 1, | ||
| "type": "markdown", | ||
| "props": { | ||
| "default_value": "<pre><code># Detect Disease From Scan\nWith this model you can lorem ipsum\n- ipsum 1\n- ipsum 2\n</code></pre>\n", |
Contributor
Author
There was a problem hiding this comment.
This is the problematic part
- typo
- typo
- move formatting checks before tests
omerXfaruq
commented
Mar 29, 2022
| 'id': 1, | ||
| 'type': 'markdown', | ||
| 'props': { | ||
| 'default_value': '<pre><code> # Detect Disease From Scan\n With this model you can lorem ipsum\n - ipsum 1\n - ipsum 2\n</code></pre>\n', |
Contributor
Author
There was a problem hiding this comment.
I got the config from from terminal with print(xray_blocks.get_config_file()), not sure why it does not comply with the test.
Thanks for the fix!
Contributor
Author
|
LGTM, feel free to merge if it is ok for you. |
abidlabs
approved these changes
Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[blocks] Test Design #894