Skip to content

Quick fix: Issue 893#907

Merged
dawoodkhan82 merged 4 commits into
blocks-devfrom
dawood/blocks-fixes
Mar 30, 2022
Merged

Quick fix: Issue 893#907
dawoodkhan82 merged 4 commits into
blocks-devfrom
dawood/blocks-fixes

Conversation

@dawoodkhan82
Copy link
Copy Markdown
Collaborator

Description

Please include:

  • relevant motivation
  • a summary of the change
  • which issue is fixed.
  • any additional dependencies that are required for this change.

Fixes: # (issue)
#893

Checklist:

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@dawoodkhan82 dawoodkhan82 requested a review from abidlabs March 30, 2022 20:48
@dawoodkhan82 dawoodkhan82 changed the base branch from main to blocks-dev March 30, 2022 20:50
@dawoodkhan82 dawoodkhan82 changed the title Quick fix: Issue #893 Quick fix: Issue 893 Mar 30, 2022
@abidlabs
Copy link
Copy Markdown
Member

LGTM, tweaked the test config so it passes!

@dawoodkhan82 dawoodkhan82 merged commit 3d880c8 into blocks-dev Mar 30, 2022
@dawoodkhan82 dawoodkhan82 deleted the dawood/blocks-fixes branch March 30, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants