Skip to content

fix file upload text#931

Merged
pngwn merged 3 commits into
blocks-devfrom
900-input
Apr 7, 2022
Merged

fix file upload text#931
pngwn merged 3 commits into
blocks-devfrom
900-input

Conversation

@pngwn
Copy link
Copy Markdown
Member

@pngwn pngwn commented Apr 6, 2022

Closes #900

@pngwn pngwn marked this pull request as ready for review April 6, 2022 17:12
@pngwn
Copy link
Copy Markdown
Member Author

pngwn commented Apr 6, 2022

Not sure if this is the only thing that needs fixing, everything else seemed to work.

@pngwn pngwn requested a review from abidlabs April 6, 2022 17:13
@abidlabs
Copy link
Copy Markdown
Member

abidlabs commented Apr 6, 2022

Hi @pngwn looks way better, but I'm still running into an issue where I can't actually download the output file. Previously, clicking on the output file would download the file, but now it has no effect:

You can test with demo\zip_two_files\run.py

image

Nit: I just noticed that when you hover your mouse over the upload-type components (image upload, file upload, etc.), it doesn't change into the "pointer cursor" that I would expect over a clickable element.

@abidlabs
Copy link
Copy Markdown
Member

abidlabs commented Apr 6, 2022

(The other demo, demo\zip_to_json\run.py works great)

@pngwn
Copy link
Copy Markdown
Member Author

pngwn commented Apr 7, 2022

@abidlabs I have cleaned up the file display a little (since it looked horrific) and added an explicit download link. This won't be final until victor has worked his magic but makes things a little more usable for now. I've also added the cursor for upload inputs.

Screenshot 2022-04-07 at 19 02 21

@abidlabs
Copy link
Copy Markdown
Member

abidlabs commented Apr 7, 2022

@pngwn pngwn merged commit 48fc3f9 into blocks-dev Apr 7, 2022
@pngwn pngwn deleted the 900-input branch April 7, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants