Blocks page load#963
Merged
Merged
Conversation
Contributor
Author
|
LoL, not sure why it authored Abubakar and me inside the commit :D |
abidlabs
reviewed
Apr 8, 2022
| ct_model, inputs=[disease, ct_scan], outputs=ct_results | ||
| ) | ||
| textbox = gr.components.Textbox() | ||
| demo.load(lambda x: x, [], [textbox]) |
Member
There was a problem hiding this comment.
This example doesn't make sense to me. The lambda function takes in an input but none is provided. Can we replace with a function that doesn't take in any inputs for it to make more sense. For example:
from datetime import datetime
def get_time():
now = datetime.now()
return now.strftime("%H:%M:%S")
demo.load(get_time, [], [textbox])
Contributor
Author
There was a problem hiding this comment.
oh I actually did that, but later I thought no need for a function definition, but you are right :D
Contributor
Author
There was a problem hiding this comment.
btw it was just a test to check the config, not a demo, but updating now.
Member
|
Besides my comment on the example, everything else looks good. But to clarify, this only implements the backend for #651, right? We still need to implement the frontend? |
Member
|
cc @pngwn |
Member
|
LGTM |
abidlabs
approved these changes
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend part of #651