fix i18n and some tweaks#966
Conversation
|
I don't actually know how to test i18n properly. |
|
For testing, you can change your browser language: https://support.google.com/chrome/answer/173424?hl=en&co=GENIE.Platform%3DDesktop ("Change the language of your Chrome browser" section) I'll also test it out now |
|
So as a solution to this, we could check if a button's value is the i18n dictionary, and if it is, we render the translated version instead |
|
@abidlabs could we change what we are hardcoding in the backend to be the language item key rather than the english string, basically just the lowercase english string? Here is the list: |
|
Yup definitely, let me push that now |
|
Actually thinking about it again, it makes more sense to update the keys in the internationalization files to be the cased versions, right? Because it doesn't make sense to "translate" from lower case to upper case (if their locale is English) In other words, what I'm saying is that if a user creates a button like |
|
Actually if you could do We can swap to Cased words in the i18n files. |

Fix i18n and a few tweaks/ cleans ups to props
Closes #933.