Skip to content

ensure dataframe updates as expected#981

Merged
pngwn merged 16 commits into
blocks-devfrom
890-input
Apr 13, 2022
Merged

ensure dataframe updates as expected#981
pngwn merged 16 commits into
blocks-devfrom
890-input

Conversation

@pngwn
Copy link
Copy Markdown
Member

@pngwn pngwn commented Apr 12, 2022

Fixes #890. Fixes #921.

(I think these are basically duplicates)

@pngwn pngwn changed the title ensure input updates as expected ensure dataframe updates as expected Apr 12, 2022
@pngwn pngwn requested a review from abidlabs April 12, 2022 16:06
@pngwn
Copy link
Copy Markdown
Member Author

pngwn commented Apr 12, 2022

Looking at the tests, it is a bit weird.

@abidlabs
Copy link
Copy Markdown
Member

Were you able to figure out the tests @pngwn? It seems like it's affecting all of the open PRs

@abidlabs
Copy link
Copy Markdown
Member

abidlabs commented Apr 12, 2022

Still running into some issues with the Dataframe component. When I run either of these demos:

  • demo\filter_records\run.py
  • demo\fraud_detector\run.py
  • demo\matrix_transpose\run.py

I get the following error in the javascript console when I hit submit:

TypeError: l.map is not a function

image

This issue prevent me from being able to test if #921 is fixed or not

@aliabid94
Copy link
Copy Markdown
Contributor

btw we want to replace the "null"s with empty space right?

@abidlabs
Copy link
Copy Markdown
Member

Yeah we should. That's a fix in the backend from None to ""

@abidlabs
Copy link
Copy Markdown
Member

Created #987 based off of this branch

@abidlabs
Copy link
Copy Markdown
Member

LGTM!

@abidlabs
Copy link
Copy Markdown
Member

@pngwn would you like to merge dataframe-nulls into this branch and then merge both into blocks-dev?

@pngwn pngwn merged commit 9cb40dc into blocks-dev Apr 13, 2022
@pngwn pngwn deleted the 890-input branch April 13, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants