ensure dataframe updates as expected#981
Merged
Merged
Conversation
Member
Author
|
Looking at the tests, it is a bit weird. |
Member
|
Were you able to figure out the tests @pngwn? It seems like it's affecting all of the open PRs |
Member
|
Still running into some issues with the
I get the following error in the javascript console when I hit submit:
This issue prevent me from being able to test if #921 is fixed or not |
Contributor
|
btw we want to replace the "null"s with empty space right? |
Member
|
Yeah we should. That's a fix in the backend from |
Member
|
Created #987 based off of this branch |
Member
|
LGTM! |
abidlabs
approved these changes
Apr 13, 2022
Member
|
@pngwn would you like to merge |
This was referenced Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #890. Fixes #921.
(I think these are basically duplicates)