-
Notifications
You must be signed in to change notification settings - Fork 112
Scope bucket sync to trackio/ subtree to avoid walking the HF cache #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+112
−4
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
120085e
Scope bucket sync to trackio/ subtree to avoid walking the HF cache
abidlabs f65aec2
add changeset
gradio-pr-bot b7df8b7
changes
abidlabs 8238c24
add changeset
gradio-pr-bot 18dd810
changes
abidlabs 7daf36e
changes
abidlabs 8c360da
Merge branch 'main' into fix-bucket-sync-hang
abidlabs c59621e
Fix Space-backed init resume metadata handling
abidlabs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "trackio": patch | ||
| --- | ||
|
|
||
| feat:Scope bucket sync to trackio/ subtree to avoid walking the HF cache |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space-backed last step lookup falls through to SQLite
Medium Severity
In
_safe_get_last_step_for_init, whenspace_id is not Noneand the Space API call succeeds but returns a non-dictsummary, execution falls through to the localSQLiteStorage.get_max_step_for_runpath instead of returningNone. The sibling function_safe_get_runs_for_initcorrectly handles this by always returning within thespace_id is not Noneblock (viareturn runs if isinstance(runs, list) else []), but here theisinstance(summary, dict)guard only returns inside theif, leaving the false branch without a return statement. This defeats the PR's goal of avoiding local SQLite/bucket access for Space-backed runs.Reviewed by Cursor Bugbot for commit 8c360da. Configure here.