fix(helm): support global registry override for sidecar#19658
Closed
Scrumplex wants to merge 1 commit intografana:mainfrom
Closed
fix(helm): support global registry override for sidecar#19658Scrumplex wants to merge 1 commit intografana:mainfrom
Scrumplex wants to merge 1 commit intografana:mainfrom
Conversation
|
|
Since grafana#19246 the sidecar image would resolve to registry-mirror.example.com/docker.io/kiwigrid/k8s-sidecar when a global registry mirror was defined. Signed-off-by: Sefa Eyeoglu <[email protected]>
Author
|
I accidentally created this PR on the main branch. I'll reopen this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Since #19246 the sidecar image would resolve to
<registry-mirror>/docker.io/kiwigrid/k8s-sidecarwhen a global registry mirror was defined.This commit handles the registry properly, the same way as all the other docker hub images.
Which issue(s) this PR fixes:
Special notes for your reviewer:
I have tested this using
helm template. Without a global registry the output is unchanged. With a global registry, it is now resolved properly.Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR