Merged
Conversation
…rufflehog tweaks - self-zizmor: call reusable-zizmor.yml@feat/zizmor-grafana-bench (correct service/suite name) - TruffleHog: send-bench-metrics default false; example workflow uses dynamic service name - Remove grafana-bench-stack (metrics via CI only); other trufflehog docs/example additions Made-with: Cursor
isaiah-grafana
force-pushed
the
feat/zizmor-grafana-bench
branch
from
ffd47d2 to
35b87da
Compare
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Points Zizmor at the shared-workflows reusable workflow (with Grafana Bench Prometheus metrics) and cleans up TruffleHog/bench wiring so only Zizmor sends metrics for now.
Changes
grafana/shared-workflows/.github/workflows/reusable-zizmor.yml@feat/zizmor-grafana-benchso service/suite name come from the caller repo (fixesservice=security→service=grafana-security-github-actions).send-bench-metricsdefault set to false; Prometheus metrics from TruffleHog are disabled for now (only Zizmor sends to Prometheus).format('grafana-{0}', github.event.repository.name)) instead of hardcoded--service security; add TruffleHog grafana-bench example and docs as needed.Dependencies
feat/zizmor-grafana-bench(or@mainafter that PR is merged). Reusable workflow provides Vault-backed Prometheus and correct caller repo naming.