perf(trufflehog): single process for PR changed-file scan#148
Closed
isaiah-grafana wants to merge 1 commit intografana:mainfrom
Closed
perf(trufflehog): single process for PR changed-file scan#148isaiah-grafana wants to merge 1 commit intografana:mainfrom
isaiah-grafana wants to merge 1 commit intografana:mainfrom
Conversation
isaiah-grafana
force-pushed
the
feat/trufflehog-single-pr-scan
branch
2 times, most recently
from
ba81ff1 to
72d4c53
Compare
Run a single trufflehog filesystem invocation with the filtered path list instead of one process per file, avoiding repeated startup cost that dominated wall time on large diffs. Made-with: Cursor
isaiah-grafana
force-pushed
the
feat/trufflehog-single-pr-scan
branch
from
72d4c53 to
3183305
Compare
Contributor
Author
|
Superseded by #151 (same-repo branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs one
trufflehog filesystemover the filtered changed-path list forpull_request/merge_groupinstead of one process per file.Why: Each invocation pays full startup (detectors, engine init). On large PRs that dominated wall time and runner cost even when per-file scan logs showed only milliseconds.
Behavior: Same excludes and same skip rules (excluded paths, missing files / deletions). Non-PR path unchanged (still scans
.once).