Skip to content

feat(compiler): Support pattern aliases#1174

Merged
ospencer merged 3 commits intomainfrom
oscar/alias-patterns
Apr 21, 2022
Merged

feat(compiler): Support pattern aliases#1174
ospencer merged 3 commits intomainfrom
oscar/alias-patterns

Conversation

@ospencer
Copy link
Copy Markdown
Member

No description provided.

@ospencer ospencer requested a review from a team March 20, 2022 22:45
@ospencer ospencer self-assigned this Mar 20, 2022
Copy link
Copy Markdown
Member

@peblair peblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magnifique 👏 🥸

@jozanza jozanza self-requested a review March 31, 2022 16:16
@marcusroberts
Copy link
Copy Markdown
Member

Does the formatter need updating for this?

Copy link
Copy Markdown
Contributor

@jozanza jozanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Copy Markdown
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So awesome! I just want a runnable test to know that constant or-pattern alias is doing what I expect

Comment thread compiler/test/suites/pattern_matching.re Outdated
@ospencer ospencer force-pushed the oscar/or-patterns branch from 808d9ce to 7765b9b Compare April 15, 2022 22:20
@ospencer ospencer force-pushed the oscar/alias-patterns branch from 96f88bf to 630e490 Compare April 15, 2022 22:31
@ospencer ospencer requested a review from phated April 15, 2022 22:31
Base automatically changed from oscar/or-patterns to main April 20, 2022 23:41
@ospencer ospencer force-pushed the oscar/alias-patterns branch from 630e490 to 98c3d2f Compare April 20, 2022 23:44
Copy link
Copy Markdown
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge approval from me!

@ospencer ospencer merged commit 9ed093b into main Apr 21, 2022
@ospencer ospencer deleted the oscar/alias-patterns branch April 21, 2022 14:55
@github-actions github-actions bot mentioned this pull request May 16, 2022
@github-actions github-actions bot mentioned this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants