feat(stdlib): add Path.removeExtension#2226
Merged
ospencer merged 1 commit intograin-lang:mainfrom Feb 16, 2025
Merged
Conversation
Member
|
Would it be better to have an |
Member
Author
I was debating an |
ospencer
reviewed
Jan 17, 2025
Member
ospencer
left a comment
There was a problem hiding this comment.
I think this is reasonable to have. I could additionally see an updateExtension to change it, but I like them being separate because it's easy to search for.
alex-snezhko
approved these changes
Feb 2, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
Path.removeExtensionto thePathlibrary as I noticed there wasn't really a great way todo it before