Bin ranges#37
Merged
josiahseaman merged 5 commits intograph-genome:masterfrom Apr 10, 2020
Merged
Conversation
sync to upstream
Member
|
I did more extensive testing from odgi build to odgi bin to CS. Looks good from my side. |
Member
|
We will JSON_VERSION = 11. |
lomereiter
reviewed
Apr 10, 2020
Member
|
Version bump hasn't been committed yet. |
Member
|
I still need to bring in new example data. |
Member
|
Checking this now. Don't worry about the merge conflict, it's minor. |
Member
|
The current data needs to be updated from odgi. data/run1.B1phi1.i1.seqwish.w1000.json doesn't have a header, so it never throws a version error. |
Member
|
Oh man, these conflicts..... |
Member
|
@subwaystation All done! In the future, please note that we won't be tracking fasta chunks beyond bin width 1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should fix #36