Support the sort of the preparation methods.#1097
Open
graphefruit wants to merge 4 commits intodevelopfrom
Open
Support the sort of the preparation methods.#1097graphefruit wants to merge 4 commits intodevelopfrom
graphefruit wants to merge 4 commits intodevelopfrom
Conversation
This sort will also rollout to the selection in the modal-popups to select or choose.
Collaborator
RagingCactus
left a comment
RagingCactus
left a comment
There was a problem hiding this comment.
I added some comments, mostly about type safety and some dead code that should be removed
src/app/preparation/preparation-sort/preparation-sort.component.html
Outdated
Show resolved
Hide resolved
src/app/preparation/preparation-sort/preparation-sort.component.html
Outdated
Show resolved
Hide resolved
src/services/preparationSortFilterHelper/preparation-sort-filter-helper.service.ts
Show resolved
Hide resolved
src/services/preparationSortFilterHelper/preparation-sort-filter-helper.service.ts
Outdated
Show resolved
Hide resolved
-> Using enum -> Fixing typos -> Removing inline css
Owner
Author
|
Thank you for the suggestions @RagingCactus ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sort will also rollout to the selection in the modal-popups to select or choose.
#1096