Issue #451 parsing filters with curlies#452
Merged
jkeen merged 7 commits intoFeb 27, 2024
Merged
Conversation
Removes side effect on passed `value` param when it's escaped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #451.
Current code behaves inconsistently:
valueis intact if it doesn't contain curly brackets, and being set to empty string if it does.According to https://en.wikipedia.org/wiki/Command%E2%80%93query_separation method should either return value or has side effects. There are cases when current code does both.
Any comments are greatly appreciated.