fix: skip introspection when IntrospectionQuery is passed as schema prop#4181
Open
trevor-scheer wants to merge 2 commits intographql:mainfrom
Open
fix: skip introspection when IntrospectionQuery is passed as schema prop#4181trevor-scheer wants to merge 2 commits intographql:mainfrom
IntrospectionQuery is passed as schema prop#4181trevor-scheer wants to merge 2 commits intographql:mainfrom
Conversation
The schema prop accepts GraphQLSchema | IntrospectionQuery | null, but shouldIntrospect only checked for GraphQLSchema via isSchema(). When an IntrospectionQuery was passed, it was ignored and a network introspection request was triggered instead. Now detects IntrospectionQuery data (via __schema check), builds a GraphQLSchema from it using buildClientSchema, and sets shouldIntrospect to false.
🦋 Changeset detectedLatest commit: 8bc206e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trevor-scheer
changed the title
IntrospectionQuery is passed as schema prop
trevor-scheer
changed the title
IntrospectionQuery is passed as schema propIntrospectionQuery is passed as schema prop
Use introspectionFromSchema to generate a properly typed fixture instead of a hand-rolled minimal object. This avoids casts and ts-expect-error while satisfying both Fetcher and IntrospectionQuery types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schema prop accepts
GraphQLSchema | IntrospectionQuery | null, butshouldIntrospectonly checked for aGraphQLSchemainstance viaisSchema. When anIntrospectionQuerywas passed, it was ignored and a network introspection request was still triggered.It now detects
IntrospectionQuerydata via__schemacheck, builds aGraphQLSchemafrom it, and correctly setsshouldIntrospecttofalse.