Conversation
…orted skipping firefox/webkit since this is not supported
Owner
|
@maxelkins I'll happily take the data generation and release script tasks (along with any e2e tests that need doing). |
Collaborator
Author
|
@grega nice one 👍 Currently the astro site is functional 🙌
I've moved over the e2e tests too and made a couple changes:
Not touched the data-generation or release stuff yet. |
… to allow importing
- Extract picker and terminal logic into src/scripts/picker.ts and terminal.ts - Terminal.astro is now a thin wiring shim (imports, no logic) - Sidebar and hints rendered by Astro; wired via delegated listeners - Hints bar uses data-hint attributes; terminal exposes typeHint() - Remove dead files: Picker.astro, public/picker.js, public/terminal.js
…ns that never actually checked anything
Collaborator
Author
|
@grega Think the migration is all done now! New astro site is at /website What I haven't done:
I'll update the PR description with more detail on changes and why. Feel free to feedback! |
Owner
|
@maxelkins this is great 👍 I'll happily get this merged, and work on the final few bits separately. |
Owner
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate site to Astro
Rewrites the project site at
/websiteusing Astro, replacing the previous vanilla HTML/JS site at/site.What changed
New Astro project (
/website)prettier-plugin-astro), and a VS Code dev launch config.tool-versionsupdated to Node 24.14.0Pages & components
index.astro— homepage/about pagedemo.astro— interactive terminal demoLayout.astro— shared HTML shellTerminal.astro— wires data and DOM refs to terminal logicStyles
reset.css,variables.css,global.css,utilities.css,compositions.cssScripts — split and modularised
picker.ts— interactive picker UI (pure module, no globals)terminal.ts— terminal emulator logic (pure module, no globals)Data generation
generate-data.shnow outputs towebsite/src/data/data.jsusing ES module syntax for use throughout the Astro sitedata.jsVHS tapes
demo/andwebsite/src/assets/(for Astro asset optimisation)E2E tests (Playwright)
site/e2e/towebsite/tests/Not included in this PR
/website; see the Astro deployment docsgenerate-data.shdemo/andwebsite/src/assets/; the README referencesdemo/. Decision pending on whether to consolidateTodos
upgrade.tool-versionswebsite/src/datato be used throughout.data.jsupdatefaviconUpdate project README