Not compatible with `parcel` package (only `parcel-bundler`)

[fregante]

🐛 Bug Report

parcel is the new official name of the package, as the readme shows: https://github.com/parcel-bundler/parcel

⚠️  Parser "@svgr/parcel-plugin-svgr/lib/asset.js" failed to initialize when processing asset "node_modules/@primer/octicons/build/svg/reply.svg". Threw the following error:
Error: Cannot find module 'parcel-bundler'
Require stack:
- ./refined-github/node_modules/@svgr/parcel-plugin-svgr/lib/asset.js
- ./refined-github/node_modules/parcel/src/Parser.js
- ./refined-github/node_modules/parcel/src/Pipeline.js
- ./refined-github/node_modules/parcel/src/worker.js
- ./refined-github/node_modules/@parcel/workers/src/child.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:793:17)
    at Function.Module._load (internal/modules/cjs/loader.js:686:27)
    at Module.require (internal/modules/cjs/loader.js:848:19)
    at require (./refined-github/node_modules/v8-compile-cache/v8-compile-cache.js:161:20)
    at Object.<anonymous> (./refined-github/node_modules/@svgr/parcel-plugin-svgr/lib/asset.js:3:22)
    at Module._compile (./refined-github/node_modules/v8-compile-cache/v8-compile-cache.js:194:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:991:10)
    at Module.load (internal/modules/cjs/loader.js:811:32)
    at Function.Module._load (internal/modules/cjs/loader.js:723:14)
    at Module.require (internal/modules/cjs/loader.js:848:19) falling back to RawAsset

To Reproduce

npm i parcel @svgr/parcel-plugin-svgr
parcel build

Try on any repo. Remove parcel-bundler and install parcel

[open-collective-bot]

Hey @fregante 👋,
Thank you for opening an issue. We'll get back to you as soon as we can.
Please, consider supporting us on Open Collective. We give a special attention to issues opened by backers.
If you use Loadable at work, you can also ask your company to sponsor us ❤️.

[gregberge]

Hi, feel free to submit a PR to fix it.

[denizdogan]

@gregberge Any chance that you could release this soon? I'd really like to use this package, but there is no official release of this fix. :)

[gregberge]

Hello @denizdogan, I have just published v5.2.0 with the fix.

[fregante]

This was supposed to be a breaking release. Anyone who runs npm install now will have a broken install because they don’t have parcel

I suggest releasing 5.2.1 immediately undoing this change and then 6.0.0 with this change

[gregberge]

@fregante oh shit... I will just wait for one day. If there is not lots of users impacted it should be good. It is a build tool, it is not critical if it breaks. If there are too much complaints I will publish a new 5.2.1. Sorry for that.

[fregante]

It is a build tool, it is not critical if it breaks

Given that build tools are used in CI/CD, today’s builds will be affected and people have to fix them to restore deployment.

It’s best to fix it now because technically it would be another breaking change for 5.2.0 users. If you change it now, there won’t be anyone who has the broken 5.2.0 in their package.json

[gregberge]

I know but right now I don't have time to do it, sorry. PR welcome.

[fregante]

PR welcome for what? You just need to re-publish the old 5.1.0 as 5.2.1 and use npm deprecate on 5.2.0. It’s just local commands

[gregberge]

@fregante nop there is also a bug fix in 5.2.0.

[fregante]

This is all something that you can do locally. There’s no code to review, it just lengthens the process.

Anyway, it doesn’t affect me, but probably it’ll ruin someone’s day