Skip to content

[cli] output relative destination paths #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregberge merged 2 commits into from
May 28, 2019
Merged

[cli] output relative destination paths #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f8f5fe
[cli] output relative destination paths
TrySound May 25, 2019
990ae13
Sort output for stable test
TrySound May 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/cli/src/__snapshots__/index.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,22 @@ export default SvgFile
"
`;

exports[`cli should transform a whole directory and output relative destination paths 1`] = `
"
__fixtures__/cased/PascalCase.svg -> __fixtures_build__/whole/cased/PascalCase.js
__fixtures__/cased/camelCase.svg -> __fixtures_build__/whole/cased/CamelCase.js
__fixtures__/cased/kebab-case.svg -> __fixtures_build__/whole/cased/KebabCase.js
__fixtures__/cased/multiple---dashes.svg -> __fixtures_build__/whole/cased/MultipleDashes.js
__fixtures__/complex/skype.svg -> __fixtures_build__/whole/complex/Skype.js
__fixtures__/complex/telegram.svg -> __fixtures_build__/whole/complex/Telegram.js
__fixtures__/nesting/a/two.svg -> __fixtures_build__/whole/nesting/a/Two.js
__fixtures__/nesting/one.svg -> __fixtures_build__/whole/nesting/One.js
__fixtures__/simple/file.svg -> __fixtures_build__/whole/simple/File.js
__fixtures__/withPrettierRc/file.svg -> __fixtures_build__/whole/withPrettierRc/File.js
__fixtures__/withSvgoYml/file.svg -> __fixtures_build__/whole/withSvgoYml/File.js
__fixtures__/withSvgrRc/file.svg -> __fixtures_build__/whole/withSvgrRc/File.js"
`;

exports[`cli should work with a simple file 1`] = `
"import React from 'react'

Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/dirCommand.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ async function dirCommand(
const dest = path.resolve(program.outDir, relative)
const code = await convertFile(src, options)
outputFileSync(dest, code)
process.stdout.write(`${src} -> ${dest}\n`)
process.stdout.write(`${src} -> ${path.relative(process.cwd(), dest)}\n`)
return true
}

Expand Down
9 changes: 7 additions & 2 deletions packages/cli/src/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,13 @@ describe('cli', () => {
expect(result).toMatchSnapshot()
}, 10000)

it('should transform a whole directory', async () => {
await cli('--out-dir __fixtures_build__/whole __fixtures__')
it('should transform a whole directory and output relative destination paths', async () => {
const result = await cli('--out-dir __fixtures_build__/whole __fixtures__')
const sorted = result
.split(/\n/)
.sort()
.join('\n')
expect(sorted).toMatchSnapshot()
}, 10000)

it('should support --prettier-config as json', async () => {
Expand Down
⚡