Skip to content

Cronet: (Set User-Agent on CronetEngine) Deleted TODO, Current beha…#12104

Merged
ejona86 merged 1 commit into
grpc:masterfrom
Sangamesh1997:Issue_fixed_11582
May 27, 2025
Merged

Cronet: (Set User-Agent on CronetEngine) Deleted TODO, Current beha…#12104
ejona86 merged 1 commit into
grpc:masterfrom
Sangamesh1997:Issue_fixed_11582

Conversation

@Sangamesh1997

Copy link
Copy Markdown
Contributor

Cronet : Set User-Agent on CronetEngine now that crbug.com/588204 is fixed .

  • No implementation changes required for user-agent handling
  • Current behavior will remain as-is
  • developer should set user-agent explicitly via hey should just explicitly call the CronetChannelBuilder I'd needed.

@shivaspeaks shivaspeaks added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label May 26, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label May 26, 2025
@ejona86 ejona86 merged commit 83538cd into grpc:master May 27, 2025
14 checks passed
@ejona86

ejona86 commented May 27, 2025

Copy link
Copy Markdown
Member

I heavily reworked the commit message.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants