Update colors to https://github.com/Marak/colors.js/pull/154/commits/b84d1acfc65d4b45ac9bbcedab276871a0109c00#20
Closed
paladox wants to merge 8 commits into
Closed
Conversation
This Marak/colors.js@2e22e4d has not be merged but fixes our problem with colors.
paladox
changed the title
Contributor
Author
|
@shama or @vladikoff could you review and merge please. |
Contributor
Author
|
I'm not sure why this fails since it shoulden since it is the same version just a minor change to fix colors configs. |
Contributor
Author
|
The test for appveyor was already broken since colors 1.1.2 by mistake wants you to switch colors on instead of having it on by default and you using --no-colors to switch colors off so the teasts wernt testing fully making them pass before and fails if it is switched on by default. |
This will need a follow up that fixes the tests so they work with colors and remove allow_failures.
Contributor
Author
|
When downgrading to colors 0.6.2 the tests failed with same error but colors 0.6.2 worked before so the tests need fixing. This can be saftly merged. |
paladox
changed the title
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Marak/colors.js@2e22e4d has not be merged but fixes our problem with colors.