[guppy] handle binary-only dependencies#174
Merged
Merged
Conversation
Some dependencies don't have lib targets. While they can't be depended on in stable Rust, there's a nightly Rust feature that enables use of binary-only dependencies. In those cases, the `resolved_name` is an empty string.
Member
Author
|
Note that this isn't a complete fix -- currently we don't have enough information to achieve that. I added this info in a subsequent commit d1e9736 |
sunshowers
added a commit
to nextest-rs/nextest
that referenced
this pull request
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some dependencies don't have lib targets. While they can't be depended on in stable Rust, there's a nightly Rust feature that enables use of binary-only dependencies. In those cases, the
resolved_nameis an empty string.Also added mnemos to our corpus.