[hakari] elide build metadata when printing dep versions#57
Merged
Conversation
Member
|
Thanks! Going to take it from here. |
sunshowers
force-pushed
the
elide-build-metadata
branch
2 times, most recently
from
2f11fbe to
be3cf38
Compare
Upcoming commits will change this code somewhat, so add some explicit tests for every possible combination.
This commit elides build metadata when printing dependency versions for the workspace-hack crate's Cargo.toml. Without this change, `cargo build` in the resulting workspace will produce a warning about superfluous build metadata (if a dependency under management has a version that includes build metadata). Do this behind a new format version to ensure that existing users don't encounter breakage. Fix guppy-rs#52. Co-authored-by: Rain <rain@sunshowers.io>
sunshowers
force-pushed
the
elide-build-metadata
branch
from
be3cf38 to
a10d53d
Compare
Contributor
Author
|
🎉 ❤️ thank you so much, @sunshowers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sunshowers I wasn't sure how to tackle the format version stuff you mentioned in #52. The existing
dep-format-versionis documented to only impact the format of theworkspace-hack = ...line that gets added to other crates, and now the format of dependencies in the workspace-hack crate itself. Wasn't sure if you wanted to add a new format version option, or just generalize thedep-format-versionoption and update the various docstrings.This commit elides build metadata when printing dependency versions for the workspace-hack crate's Cargo.toml. Without this change,
cargo buildin the resulting workspace will produce a warning about superfluous build metadata (if a dependency under management has a version that includes build metadata).Fix #52.