Prevent possible warnings on unset variables

[sudo-plz]

PHP version: 8.0

Problem
Our server supplies the following value in $_FILES

{
    "files": {
         "tmp_name":["\/tmp\/upload-file-h1gjcc"],
         "name":["file.pdf"]
    }
}

Causing warnings such as:

PHP Warning: Undefined array key "size" in /srv/vendor/guzzlehttp/psr7/src/ServerRequest.php on line 147
PHP Warning: Trying to access array offset on value of type null in /srv/vendor/guzzlehttp/psr7/src/ServerRequest.php on line 147
PHP Warning: Undefined array key "error" in /srv/vendor/guzzlehttp/psr7/src/ServerRequest.php on line 148
PHP Warning: Trying to access array offset on value of type null in /srv/vendor/guzzlehttp/psr7/src/ServerRequest.php on line 148

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 2 weeks if no further activity occurs. Thank you for your contributions.

[sudo-plz]

@GrahamCampbell Can you please take a look?

[GrahamCampbell]

Thanks for the PR. Can you add test coverage please?

[sudo-plz]

Thanks for your feedback, I added some cases, I hope its up to your standards!

Update: Currently searching why Psalm suddenly decided to call out some unrelated improvements. Are you fine with just updating the baselines?

[TimWolla]

Update: Currently searching why Psalm suddenly decided to call out some unrelated improvements. Are you fine with just updating the baselines?

I suspect this is because of psr/http-message 1.1 being tagged.

[TimWolla]

@sudo-plz I've spun out the update for the psr/http-message interfaces and the baselines into #551.

[GrahamCampbell]

Please revert the baseline changes, and leave it to fail, so that the PR is atomic.

[GrahamCampbell]

Great, thanks.

[GrahamCampbell]

We are likely going to do a 2.4.5 release on Monday 17th, so this will be included in that. 🎉