feat(csp): set nonce attribute for injected styles if available#328
Merged
feat(csp): set nonce attribute for injected styles if available#328
Conversation
obartra
approved these changes
Dec 15, 2017
Uses a fork of cxs that sets a nonce attribute to the injected style tag if it is globally available. Related cxs PR to merge this functionality into the base lib: cxs-css/cxs#97
arahansen
force-pushed
the
arahansen/csp
branch
from
17bdeff to
e84d511
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses a fork of cxs that sets a nonce attribute to the injected style tag if it is globally available. Related cxs PR to merge this functionality into the base lib: cxs-css/cxs#97
Also, we don't need to use my fork of flow-copy-source anymore since we don't need css flow support now.
FYI: I'm a little skeptical of getting my fork merged into the cxs library anytime soon. 1, it seems the maintainer has not had a lot of time to review PRs lately, and 2, given that the whole selling point of the library is tiny css-in-js, he may be against adding functionality that isn't totally essential to what the lib does.