build fixes#34
Open
tsailerddln wants to merge 1 commit into
Open
Conversation
protobuf: in line 44 cmake snippets are included from
${PROTOBUF_INSTALL_DIR}/lib/cmake/protobuf, so it should be made sure
that they are actually installed in lib (and not lib64), therefore add
CMAKE_INSTALL_LIBDIR=lib.
hef_proto, scheduler_mon_proto and profiler_proto are private libraries
that are not meant to be installed but are used by libhailort, so make
sure they are built as static libraries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
protobuf: in line 44 cmake snippets are included from ${PROTOBUF_INSTALL_DIR}/lib/cmake/protobuf, so it should be made sure that they are actually installed in lib (and not lib64), therefore add CMAKE_INSTALL_LIBDIR=lib.
hef_proto, scheduler_mon_proto and profiler_proto are private libraries that are not meant to be installed but are used by libhailort, so make sure they are built as static libraries.