Skip to content

fix: protect link recursion from max call stack#3113

Merged
Marsup merged 1 commit into
masterfrom
fix/link-max-call-stack
May 4, 2026
Merged

fix: protect link recursion from max call stack#3113
Marsup merged 1 commit into
masterfrom
fix/link-max-call-stack

Conversation

@Marsup

@Marsup Marsup commented May 4, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@Marsup Marsup added this to the 18.2.1 milestone May 4, 2026
@Marsup Marsup added the bug Bug or defect label May 4, 2026
@Marsup Marsup self-assigned this May 4, 2026
@Marsup Marsup merged commit 2392713 into master May 4, 2026
9 checks passed
@Marsup Marsup deleted the fix/link-max-call-stack branch May 4, 2026 16:10
@renovate renovate Bot mentioned this pull request Jun 11, 2026
Merged
1 task
@sc-renovate sc-renovate Bot mentioned this pull request Jun 11, 2026
Open
1 task
This was referenced Jun 11, 2026
Open
Open
This was referenced Jun 11, 2026
Open
Open
@pedrofurtado-cw

pedrofurtado-cw commented Jun 11, 2026

Copy link
Copy Markdown

@Marsup This fix will be provided for 17.x?

@renovate renovate Bot mentioned this pull request Jun 11, 2026
Open
1 task
This was referenced Jun 11, 2026
Open
Open
Closed
Open
This was referenced Jun 11, 2026
Merged
Open
This was referenced Jun 11, 2026
Open
Closed
@renovate renovate Bot mentioned this pull request Jun 11, 2026
Merged
1 task
@daniel-renovator daniel-renovator Bot mentioned this pull request Jun 11, 2026
Open
1 task
This was referenced Jun 11, 2026
Merged
Open
Closed
Open
Merged
Closed
@renovate renovate Bot mentioned this pull request Jun 12, 2026
Open
1 task
@tats-u

tats-u commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Docusaurus uses v17. A backport is necessary.

This was referenced Jun 12, 2026
Open
Open
Merged
Merged
Open
Closed
Open
@Marsup

Marsup commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

@pedrofurtado-cw I wasn't planning on it but I think it's doable. What's your reason out of curiosity?

@tats-u I see joi 18 in docusaurus, where is 17?

@tats-u

tats-u commented Jun 12, 2026

Copy link
Copy Markdown

It has been updated in main, but not in the latest stable release.

facebook/docusaurus#11988

facebook/docusaurus@ebd76d8

This commit has not been included in any versions.

Marsup added a commit that referenced this pull request Jun 12, 2026
@Marsup
Merge pull request #3123 from hapijs/chore/backport-3113
4bcdf36 
chore: backport #3113 to v17
@Marsup

Marsup commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

Released as 17.13.4.

@tats-u

tats-u commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Sorry for the extra work, and thank you for your prompt response.

@harjot339

harjot339 commented Jun 12, 2026

Copy link
Copy Markdown

@Marsup I'm still seeing GHSA-q7cg-457f-vx79 reported by yarn audit with joi@17.13.4 installed.

Since the fix was backported to 17.13.4, is the advisory metadata still pending an update? This currently appears to be a false positive.

@Marsup

Marsup commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

I just updated it, I'm not sure how long it takes to propagate.

@tats-u

tats-u commented Jun 12, 2026

Copy link
Copy Markdown

We appreciate your quick response again.

This was referenced Jun 12, 2026
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Marsup Marsup

Labels

bug Bug or defect

Projects

None yet

Milestone

18.2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Marsup @pedrofurtado-cw @tats-u @harjot339
⚡