fix: terminate worker threads after block evaluation in policy-service#6075
Merged
Merged
Conversation
Three policy blocks spawn worker_threads Workers via `new Worker(...)` but never call worker.terminate(). Node Worker threads do not auto-exit when the script body returns — they keep the V8 isolate alive (~30 MB each) waiting for more messages on the parentPort. Every formula / custom-logic / data-transformation invocation leaked one worker thread. A heavy policy could accumulate multi-GB of leaked workers over the course of an MRV submission. Adds a small cleanup() helper that calls worker.terminate() (with a swallowed .catch() for already-exited workers, e.g. via OOM-kill). Called on the terminating message, on error, and on every reject path. - math-block.ts: terminate on the single 'done' message + on error - custom-logic-block.ts (JS branch): terminate after the final 'done' (data.final === true) so debug messages are still forwarded for multi-emit custom-logic runs. Python branch already has timeout-based termination + an 'exit' handler and is left untouched. - data-transformation-addon.ts: terminate after final result + on error No public API change. Behavior unchanged for callers; resources are now released after each block evaluation.
vshvets-bc
changed the title
Pyatakov
changed the title
Pyatakov
requested changes
May 27, 2026
Co-authored-by: Alex Piatakov <alexander.piatakov@gmail.com> Signed-off-by: Volodymyr Shvets <54721244+vshvets-bc@users.noreply.github.com>
…don.ts Co-authored-by: Alex Piatakov <alexander.piatakov@gmail.com> Signed-off-by: Volodymyr Shvets <54721244+vshvets-bc@users.noreply.github.com>
Co-authored-by: Alex Piatakov <alexander.piatakov@gmail.com> Signed-off-by: Volodymyr Shvets <54721244+vshvets-bc@users.noreply.github.com>
Pyatakov
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three policy blocks spawn worker_threads Workers via
new Worker(...)but never call worker.terminate().Node Worker threads do not auto-exit when the script body returns — they keep the V8 isolate alive (~30 MB each) waiting for more messages.
Every formula / custom-logic / data-transformation invocation leaked one worker thread. A heavy policy could accumulate multi-GB of leaked workers.
Adds a small cleanup() helper that calls worker.terminate() (with a swallowed .catch() for already-exited workers, e.g. via OOM-kill). Called on the terminating message, on error, and on every reject path.
Behavior unchanged for callers; resources are now released after each block evaluation.