Skip to content

feat(detector): provide a detector for repository hosted on GitLab.com#259

Merged
azr merged 1 commit intohashicorp:masterfrom
davinkevin:feat-detector-support-gitlab-com-urls
Sep 16, 2020
Merged

feat(detector): provide a detector for repository hosted on GitLab.com#259
azr merged 1 commit intohashicorp:masterfrom
davinkevin:feat-detector-support-gitlab-com-urls

Conversation

@davinkevin
Copy link
Copy Markdown
Contributor

This is a really simple implementation based on the GitHub detector for GitLab URL. It only supports URL with format gitlab.com/username/repo

@hashicorp-cla
Copy link
Copy Markdown

hashicorp-cla commented Jun 7, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Contributor

@azr azr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread detect_gitlab.go Outdated
Comment thread detect_gitlab.go Outdated
@davinkevin davinkevin force-pushed the feat-detector-support-gitlab-com-urls branch from 1fba7b1 to 4d87346 Compare September 15, 2020 17:04
@azr azr merged commit 437601e into hashicorp:master Sep 16, 2020
@azr
Copy link
Copy Markdown
Contributor

azr commented Sep 16, 2020

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants