Merged
Conversation
vancluever
force-pushed
the
hcldec-add-validatefuncspec
branch
from
ba66c17 to
f12e44b
Compare
apparentlymart
approved these changes
Jun 4, 2020
Contributor
apparentlymart
left a comment
apparentlymart
left a comment
There was a problem hiding this comment.
Nice! The approach here seems fine to me. I've left some feedback inline about some minor things, but the approval is intended to mean that I'm fine with moving straight to merge without another round of reviewing unless you want to discuss that feedback further.
This adds ValidateSpec, a new decoder Spec that allows one to add custom validations to work with values at decode-time. The validation is run on the value after the wrapped spec is applied to the expression in question. Diagnostics are expected to be returned, with the author having flexibility over whether or not they want to specify a range; if one is not supplied, the range of the wrapped expression is used.
vancluever
force-pushed
the
hcldec-add-validatefuncspec
branch
from
f12e44b to
9c4784b
Compare
Contributor
Author
|
Done deal! Will be merging shortly 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds ValidateFuncSpec, a new decoder Spec that allows one to add
custom validations to work with values at decode-time.
The validation is run on the value after the wrapped spec is applied to
the expression in question. Diagnostics are expected to be returned,
with the author having flexibility over whether or not they want to
specify a range; if one is not supplied, the range of the wrapped
expression is used.