hclsyntax: Report correct Range.End for FunctionCall w/ incomplete arg#588
Merged
radeksimko merged 1 commit intomainfrom Feb 10, 2023
Merged
hclsyntax: Report correct Range.End for FunctionCall w/ incomplete arg#588radeksimko merged 1 commit intomainfrom
radeksimko merged 1 commit intomainfrom
Conversation
radeksimko
force-pushed
the
b-fix-func-closetok-parsing
branch
4 times, most recently
from
c01356e to
85634f7
Compare
radeksimko
force-pushed
the
b-fix-func-closetok-parsing
branch
from
85634f7 to
a3ce77c
Compare
5 tasks
alisdair
approved these changes
Feb 10, 2023
Contributor
alisdair
left a comment
alisdair
left a comment
There was a problem hiding this comment.
I don't know how to usefully review the parser_test changes, but the change to parser.go seems logical to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #582
Passing tests suggest this isn't breaking anything else, but I'm open to suggestions for any more (careful) changes to avoid any unforeseen consequences.