Skip to content

Preserve marks when traversing unknown values#699

Merged
jbardin merged 1 commit intomainfrom
jbardin/marked-traversals
Sep 24, 2024
Merged

Preserve marks when traversing unknown values#699
jbardin merged 1 commit intomainfrom
jbardin/marked-traversals

Conversation

@jbardin
Copy link
Copy Markdown
Member

@jbardin jbardin commented Sep 24, 2024

When traversing an unknown value or a DynamicVal, the marks from that initial value must be preserved for HCL Index and GetAttr operations. This mirrors the behavior of GetAttr and Index when used directly the underlying cty values.

When traversing an unknown value or a DynamicVal, the marks from that
initial value must be preserved for HCL Index and GetAttr operations.
This mirrors the behavior of GetAttr and Index when used directly the
underlying cty values.
@jbardin jbardin requested review from a team and alisdair September 24, 2024 16:56
Copy link
Copy Markdown
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jbardin jbardin merged commit 78fe993 into main Sep 24, 2024
@jbardin jbardin deleted the jbardin/marked-traversals branch September 24, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants