Bump packer-plugin-sdk to address legacy SSH key algorithms in SSH communicator#218
Merged
Bump packer-plugin-sdk to address legacy SSH key algorithms in SSH communicator#218
Conversation
sylviamoss
approved these changes
May 4, 2022
sylviamoss
left a comment
sylviamoss
left a comment
There was a problem hiding this comment.
Nice! Good idea adding the test case 👍🏼
| locals { timestamp = regex_replace(timestamp(), "[- TZ:]", "") } | ||
|
|
||
| source "amazon-ebs" "basic-example" { | ||
| ami_description = "Ubuntu 22.04 GoldenImage" |
There was a problem hiding this comment.
Do you know this one tests what you need because of the ubuntu version?
Contributor
Author
There was a problem hiding this comment.
Yes, this particular version of ubuntu runs openssh version 8.9 which requires stronger ssh key algorithms, as of openssh 8.8. I added a comment to the HCL file. But maybe I should add one here?
There was a problem hiding this comment.
I think it looks good the way it is!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes hashicorp/packer#11623
Closes hashicorp/packer#11733
Closes #213