source.id to source.virtualMachineId#474
Closed
anshulsharma-hashicorp wants to merge 2 commits intomainfrom
Closed
source.id to source.virtualMachineId#474anshulsharma-hashicorp wants to merge 2 commits intomainfrom
anshulsharma-hashicorp wants to merge 2 commits intomainfrom
Conversation
|
|
|
|
||
| // First check if the parent Gallery Image Version source ID is a managed image, if so we use that as our source image name | ||
| parentSourceID := *image.Properties.StorageProfile.Source.Id | ||
| parentSourceID := *image.Properties.StorageProfile.Source.VirtualMachineId |
Contributor
There was a problem hiding this comment.
as i mentioned in slack, this breaks HCP Packer ancestry for SIG images that are sourced from a managed image, this does not fix the user issue y'all are concerned about with the deprecation on march 15th, so I don't think we should merge this change, thanks for taking a crack at in @anshulsharma-hashicorp
Contributor
|
Closing this PR as we discussed in slack as it shouldn't be needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DELETE THIS TEMPLATE BEFORE SUBMITTING
In order to have a good experience with our community, we recommend that you
read the contributing guidelines for making a PR, and understand the lifecycle
of a Packer Plugin PR:
https://github.com/hashicorp/packer-plugin-azure/blob/main/.github/CONTRIBUTING.md#opening-an-pull-request
Describe the change you are making here!
Please include tests. We recommend looking at existing tests as an example.
If your PR resolves any open issue(s), please indicate them like this so they will be closed when your PR is merged:
Closes #xxx
Closes #xxx