Clearly log result of failing to get the source name for SIG-sourced builds.#476
Merged
JenGoldstrich merged 1 commit intomainfrom Mar 22, 2025
Merged
Clearly log result of failing to get the source name for SIG-sourced builds.#476JenGoldstrich merged 1 commit intomainfrom
JenGoldstrich merged 1 commit intomainfrom
Conversation
JenGoldstrich
force-pushed
the
log_source_image_name_error
branch
from
eabc6f1 to
ebeb6ec
Compare
JenGoldstrich
force-pushed
the
log_source_image_name_error
branch
from
ebeb6ec to
d3bc5e4
Compare
aklkv
approved these changes
Mar 21, 2025
JenGoldstrich
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user reported issues with HCP Packer ancestry, they didn't know the issue was caused by the Azure API because the plugin doesn't make it clear what will result from being unable to set the source image name
To make this clearer that this is an actual error which may be a plugin bug, or user configuration error, we want to actually log the Azure API error.