Bump Azure SDK to newer versions in builder etc.#563
Open
atombrella wants to merge 1 commit intohashicorp:mainfrom
Open
Bump Azure SDK to newer versions in builder etc.#563atombrella wants to merge 1 commit intohashicorp:mainfrom
atombrella wants to merge 1 commit intohashicorp:mainfrom
Conversation
Contributor
Author
|
@tanmay-hc I'll revert the last commit. It turns out that the VMSS is where we want to set |
4cdb597 to
b98f652
Compare
c8ea284 to
b697262
Compare
We would quite like support for StandardSSD_LRS for creating new VM images.
b697262 to
21ea11b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Various Azure SDK have been bumped to the newest. Except for a couple of places, the changes are just in the import-sections. The tests are passing.
We would quite like support for
StandardSSD_LRSfor creating new VM images. This would reduce some cost for us. The possible values function for the supported storage account type supports with one of the newer Azure APIs.No new tests have been added. I can try to add one with
StandardSSD_LRS. Perhaps documentation also needs to be adjusted. Anyway, we are pretty eager to have support for this.Resolved Issues
If your PR resolves any open issue(s), please indicate them like this so they will be closed when your PR is merged:
Closes #xxx
Closes #xxx
Rollback Plan
If a change needs to be reverted, we will roll out an update to the code within 7 days.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.