Fix pageUp and pageDown boot command usb key strokes#46
Merged
sylviamoss merged 1 commit intomainfrom Mar 30, 2021
Merged
Conversation
Author
|
User confirmed the changes work hashicorp/packer#10796 (comment) |
azr
reviewed
Mar 30, 2021
| "home": key.CodeHome, | ||
| "end": key.CodeEnd, | ||
| "pageUp": key.CodePageUp, | ||
| "pageDown": key.CodePageDown, |
Contributor
There was a problem hiding this comment.
Does that mean that pageUp will stop working ? and only pageup will ?
Author
There was a problem hiding this comment.
They never worked. The keystrokes are lowercased before matching the map. All of the others are lowercased I don't know why I added these two camel-cased in the first place. 🤔
azr
approved these changes
Mar 30, 2021
Contributor
azr
left a comment
azr
left a comment
There was a problem hiding this comment.
Had a tiny question, other than that LGTM !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/packer#10796