Updating comments for cache and config directories to be accurate#73
Merged
azr merged 1 commit intohashicorp:mainfrom Aug 4, 2021
Merged
Conversation
sylviamoss
approved these changes
Jul 29, 2021
sylviamoss
left a comment
sylviamoss
left a comment
There was a problem hiding this comment.
LGTM 👍🏼 I'll give @azr a change to review too before merging it.
azr
approved these changes
Aug 4, 2021
Contributor
azr
left a comment
azr
left a comment
There was a problem hiding this comment.
Many thanks for addressing this ! @teddylear LGTM !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing last comment from @azr on previous pr before it got merged to update comments to be more accurate and fix issues in comments. @azr Please let me know if there is anything else I should update with these comments.
Addresses: hashicorp/packer#9007