Skip to content

Fix plugin-check cmd for provisioner only plugins #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nywilken merged 1 commit into from
Nov 11, 2021
Merged

Fix plugin-check cmd for provisioner only plugins #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/packer-sdc/internal/plugincheck/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## `plugin-check`

`plugin-check` will check wether a plugin binary seems to work with packer.
`plugin-check` will check whether a plugin binary seems to work with packer.

Use: `packer-sdc plugin-check packer-plugin-happy-cloud`
3 changes: 2 additions & 1 deletion cmd/packer-sdc/internal/plugincheck/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ func (cmd *Command) run(args []string) error {
return errors.New("APIVersion needs to be set")
}

if len(desc.Builders) == 0 && len(desc.PostProcessors) == 0 && len(desc.Datasources) == 0 {
if len(desc.Builders) == 0 && len(desc.PostProcessors) == 0 && len(desc.Datasources) == 0 && len(desc.Provisioners) == 0 {
return errors.New("this plugin defines no component.")
}
return nil
Expand All @@ -92,6 +92,7 @@ type pluginDescription struct {
Builders []string `json:"builders"`
PostProcessors []string `json:"post_processors"`
Datasources []string `json:"datasources"`
Provisioners []string `json:"provisioners"`
}

func isOldPlugin(pluginName string) bool {
Expand Down
⚡