Investigate Integration Tests

[skorfmann]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

cdktf & Language Versions

• all

Affected Resource(s)

• integration tests

Expected Behavior

Integration tests should pass when a green PR is being merged

Actual Behavior

Sometimes, a green build in a PR is causing an error when being merged - e.g. #276

Steps to Reproduce

• ?

Important Factoids

The failing master build https://github.com/hashicorp/terraform-cdk/runs/1009651711
The succeeding PR build https://github.com/hashicorp/terraform-cdk/runs/1005934406

References

• Migrate to jsii-srcmak #276

[jsteinich]

I did a diff of two local test runs. The only difference was the version of typescript.
In the successful test (#276 branch) the version was 3.9.7
In the unsuccessful test (master before #332 merged) the version was 4.0.2

[skorfmann]

In the unsuccessful test (master before #332 merged) the version was 4.0.2

I was just trying to find this dependency, but can't find it anywhere. Any clue?

[skorfmann]

Was #332 up to date with master? I just merged #314 without rebasing against master. I think that's a general issue as well.

[jsteinich]

In the unsuccessful test (master before #332 merged) the version was 4.0.2

I was just trying to find this dependency, but can't find it anywhere. Any clue?

I'm not finding it either.

Was #332 up to date with master?

Yes.

I just merged #314 without rebasing against master. I think that's a general issue as well.

As far as I'm aware, the action checkout step checks out a version of the pr that is already merged into master, so I don't think that's a problem.

[skorfmann]

As far as I'm aware, the action checkout step checks out a version of the pr that is already merged into master, so I don't think that's a problem.

yes, that would make sense.

[skorfmann]

I don't think we have any actionable items left here. Let's get back to this, if this happens again.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.