Skip to content
This repository was archived by the owner on Dec 10, 2025. It is now read-only.

chore: add missing dependency on fs-extra to @cdktf/hcl-tools#3854

Merged
mutahhir merged 3 commits intohashicorp:mainfrom
Veetaha:feat/missing-fs-extra
Apr 17, 2025
Merged

chore: add missing dependency on fs-extra to @cdktf/hcl-tools#3854
mutahhir merged 3 commits intohashicorp:mainfrom
Veetaha:feat/missing-fs-extra

Conversation

@Veetaha
Copy link
Copy Markdown
Contributor

@Veetaha Veetaha commented Apr 16, 2025

Related issue

Fixes #3852

Description

Added the missing fs-extra dependency to package.json that is used here:

import * as fs from "fs-extra";

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@xiehan
Copy link
Copy Markdown
Member

xiehan commented Apr 16, 2025

Good catch! Could you also add the package to the list here? I believe that's why this got missed in the first place.

@Veetaha
Copy link
Copy Markdown
Contributor Author

Veetaha commented Apr 16, 2025

Extended depcheck 👌

@xiehan xiehan changed the title fix(@cdktf/hcl-tools): add missing dependency on fs-extra to @cdktf/hcl-tools chore: add missing dependency on fs-extra to @cdktf/hcl-tools Apr 17, 2025
Copy link
Copy Markdown
Member

@mutahhir mutahhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thank you!

@mutahhir mutahhir merged commit fd93f60 into hashicorp:main Apr 17, 2025
440 of 566 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@cdktf/hcl-tools: npm package is missing dependency on fs-extra

3 participants