This repository was archived by the owner on Dec 10, 2025. It is now read-only.
chore: Ensure build succeeds if go version 1.24 is used#3859
Closed
chore: Ensure build succeeds if go version 1.24 is used#3859
Conversation
DanielMSchmidt
approved these changes
Apr 22, 2025
Member
Author
|
Going to stash this one. While this solves the problem of using the right folder for the wasm_exec.js file, you still can't seem to run CDKTF against latest versions of Go. The error seems to be stemming from the yoga-layout-prebuilt library for now at first glance, but it might just be appearing that way. Haven't investigated. |
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As of this commit, Go changes the location of the wasm_exec.js file. This PR updates our build script to be resilient to this change.
Checklist