Skip to content
This repository was archived by the owner on Dec 10, 2025. It is now read-only.

chore: Ensure build succeeds if go version 1.24 is used#3859

Closed
mutahhir wants to merge 1 commit intomainfrom
chore/make-build-work-with-go-1-24
Closed

chore: Ensure build succeeds if go version 1.24 is used#3859
mutahhir wants to merge 1 commit intomainfrom
chore/make-build-work-with-go-1-24

Conversation

@mutahhir
Copy link
Copy Markdown
Member

Description

As of this commit, Go changes the location of the wasm_exec.js file. This PR updates our build script to be resilient to this change.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@mutahhir mutahhir requested a review from a team as a code owner April 22, 2025 12:37
@mutahhir mutahhir requested review from DanielMSchmidt and ansgarm and removed request for a team April 22, 2025 12:37
@mutahhir
Copy link
Copy Markdown
Member Author

Going to stash this one. While this solves the problem of using the right folder for the wasm_exec.js file, you still can't seem to run CDKTF against latest versions of Go. The error seems to be stemming from the yoga-layout-prebuilt library for now at first glance, but it might just be appearing that way. Haven't investigated.

@mutahhir mutahhir closed this May 19, 2025
@github-actions
Copy link
Copy Markdown
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants